Re: Removing libgnome dependency



On Sat, 2008-10-04 at 12:07 -0400, Mike Rooney wrote:
> > Last follow-up for today:
> 
> Is it really a good idea to remove a constant variable and instead
> replace it with the value throughout (replacing GNOME_PAD with 8
> everywhere)? That doesn't seem to follow principals of good software
> design or reuse. What is wrong with defining that in a constants file?
> Maybe I am just confused...

We don't consistenly use it in any way, and almost all code hardcodes
sizes anyway, so this is not really a regression.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]