Re: Removing libgnome dependency

[Alexander Larsson <alexl redhat com>]

On Sat, 2008-10-04 at 14:14 +0200, Cosimo Cecchi wrote:
> On Fri, 2008-10-03 at 19:26 +0200, Cosimo Cecchi wrote:
> 
> > I am currently working on gnome_program, gnome_help, gnome_popup_menu
> > and gnome_authentication_manager, will post a patch soon.
> 
> You can find my work so far in the attached patches.
> I hopefully dropped all references to gnome_program, gnome_config,
> gnome_authentication, gnome_color_picker and the use of the GNOME_*
> class/type definition macros inside Nautilus.
> I now plan to have a look at gnome_icon_entry and gnome_popup_menu; in
> the meantime, is it OK to commit these to trunk?

Commited, with some fixed issues:

-       eel_gdk_color_parse (color_spec, &color);
-       color.red >>= 8;
-       color.green >>= 8;
-       color.blue >>= 8;
-       
+       gdk_color_parse (color_spec, &color);


We still have to do that shifting.

Index: src/Makefile.am
===================================================================
--- src/Makefile.am	(revision 14682)
+++ src/Makefile.am	(working copy)
@@ -19,6 +19,7 @@ INCLUDES =							\
 	-DDATADIR=\""$(datadir)"\" 				\
 	-DLIBDIR=\""$(libdir)"\" 				\
 	-DNAUTILUS_DATADIR=\""$(datadir)/nautilus"\" 		\
+	-DGNOMELOCALEDIR=\""$(datadir)/locale"\"		\
 	-DGLADEDIR=\""$(datadir)/nautilus/glade"\" 		\
 	-DNAUTILUS_PIXMAPDIR=\""$(datadir)/pixmaps/nautilus"\" 	\
 	-DPREFIX=\""$(prefix)"\" 				\

Why is this needed?

+				basename = g_path_get_basename (kde_trash_dir);
+				g_free (kde_trash_dir);
...
+				g_free (kde_trash_dir);

Double free.