Re: automounting / autorunning

[Alexander Larsson <alexl redhat com>]

On Thu, 2008-01-17 at 00:58 -0500, David Zeuthen wrote:
> Hi,
> 
> On Tue, 2008-01-15 at 10:47 +0100, Alexander Larsson wrote:
> > You should probably only do this if on startup if the automount
> > preference is set.
> 
> Done. Btw, we're probably automounting in the wrong place, e.g. too
> early: If nautilus is already running and you start another instance
> this code will run an the other instance will exit too. You probably
> know better than me where to move it.
> 
> > Also, there is still some coding style issues. Nautilus always uses
> > brackets everywhere, even if there is only one line in the block.
> 
> I think I've fixed this. It's a bit confusing because gio/gvfs uses
> another coding style.
> 
> > > There's also a small gvfs patch that fixes some bugs with the hal
> > > backend that I ran into when doing all this. The patches are here
> > 
> > > http://people.freedesktop.org/~david/gvfs-hal-stuff.patch
> > 
> > I'm commiting this, as I'm working on the mount stuff in nautilus.
> 
> Here's an updated version
> 
> http://people.freedesktop.org/~david/nxct-glib.patch
> 
> This fixes a bug where the returned GIcon isn't reffed.

It shouldn't ref it. (See previous discussion on gtk-devel-list on
getters vs refing for details.)

> http://people.freedesktop.org/~david/nxct-gvfs.patch
> 
> Partly some work on getting LUKS to work properly (needs more work; am
> doubtful it can properly fixed without major fixes to underlying
> subsystems. Oh well.).

Commited.


> http://people.freedesktop.org/~david/nxct-nautilus.patch
> 
> This is the big patch. It adds the following features (in addition to
> those described in the last mail).
> 

The startup automount list is kinda ugly. I'm switching this to a user
data property.

Also, the way you detect content types is not really nice. You're doing
sync I/O to find things like the enclosing volume, etc, which is a major
no-no in Nautilus. And having a separated out call for getting some
information about files instead of using the Nautilus i/o machinery is
also pretty weird. I'll try to fix this up.

>        Wouldn't it be a lot easier to just represent computer:///
>        through custom code in Nautilus (much like mount icons on the
>        desktop)? If we did that it would be easier to create a more
>        optimized layout like e.g.
> 
>        http://www.dhtmlnirvana.com/screenshots/vista_005.jpg
> 
>        e.g. both categorizations and details like conveying free
>        space etc.
> 
>        Is computer:/// even used outside Nautilus?

Having virtual locations like the desktop is a major piece of pain. No
other app can access this, the URI scheme is unknown to all other apps,
and it generally needs lots of special casing all over the nautilus
codebase to work. 

If there is something we require to do for this we should try to add
that to gio so we can implement it in computer:/// instead.