Re: Patch to fix #314139 [REVISION PROPOSAL]

[Alexander Larsson <alexl redhat com>]

On Wed, 2006-06-14 at 12:34 +0300, Sivan Greenberg wrote:
> On Wed, 2006-06-14 at 09:05 +0200, Alexander Larsson wrote:
> 
> > You might as well use g_stat() if you're working on local files only.
> > Just get a path with gnome_vfs_get_local_path_from_uri(). (This is also
> > an automatic check for local files, since it returns NULL for other
> > uris.)
> 
> I hope it's going to be easy as it seems ;-). On a related note, why are
> g_stat() and gnome_vfs_get_local_path_from_uri() cached while the ones
> I've used in my patch are not? (gnome_vfs_get_local_path_from_uri() ,
> (gnome_vfs_get_file_info_uri())

They are not cached. You have to implement that yourself. The reason to
use g_stat directly is just to avoid lots of levels of indirection and
bloat when its not needed (i.e. you're only doing this for local files
anyway).

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a sword-wielding one-eyed jungle king on his last day in the job. She's a 
man-hating goth mercenary who believes she is the reincarnation of an ancient 
Egyptian queen. They fight crime!