Re: [PATCH] Use GdkPixbufLoader for thumbnailer to reduce memory consumption

[Christian Neumair <chris gnome-de org>]

Am Samstag, den 08.04.2006, 14:33 +0200 schrieb Martin Wehner:
> On Sat, 2006-04-08 at 13:24 +0200, Christian Neumair wrote:
> > Am Samstag, den 08.04.2006, 01:59 +0200 schrieb Martin Wehner:                                                            
> > > >         if (error != NULL);                                                                                  
> > > >                 g_error_free (error);
> > > 
> > > This looks like it doesn't do what you intended.
> > 
> > Why?
> 
> There's a semicolon after the conditional which made it a null
> statement.

Ouch, thanks. Shouldn't we have compiler flags that ensure that this
produces a warning (-Wextra)?

> The framing logic isn't the same as before. There are certain images
> that get a frame now that didn't before and vice versa. Totem thumbnails
> at low zoom levels didn't get one before but do now. Some images in
> ~/backgrounds don't get a frame anymore at low zoom now, but did before.
> I think the size comparison in
> 
> > +if ((is_thumbnail || size > NAUTILUS_ICON_SIZE_THUMBNAIL) && !
> > gdk_pixbuf_get_has_alpha (pixbuf)) {
> 
> doesn't do the same as it did before because the pixmap has already been
> scaled at that point now.

To be honest I don't understand why we're adding frames to pixbufs that
don't come from ~/.thumbnails at all.

-- 
Christian Neumair <chris gnome-de org>