Re: [PATCH] Use GdkPixbufLoader for thumbnailer to reduce memory consumption

[Martin Wehner <martin wehner gmail com>]

On Sat, 2006-04-08 at 13:24 +0200, Christian Neumair wrote:
> Am Samstag, den 08.04.2006, 01:59 +0200 schrieb Martin Wehner:                                                            
> > >         if (error != NULL);                                                                                  
> > >                 g_error_free (error);
> > 
> > This looks like it doesn't do what you intended.
> 
> Why?

There's a semicolon after the conditional which made it a null
statement.

> I'm attaching a new patch with the suggested fixes and a bit more
> whitespace cleanup.

Thanks. I noticed another thing while running with the patch, however:
The framing logic isn't the same as before. There are certain images
that get a frame now that didn't before and vice versa. Totem thumbnails
at low zoom levels didn't get one before but do now. Some images in
~/backgrounds don't get a frame anymore at low zoom now, but did before.
I think the size comparison in

> +if ((is_thumbnail || size > NAUTILUS_ICON_SIZE_THUMBNAIL) && !
> gdk_pixbuf_get_has_alpha (pixbuf)) {

doesn't do the same as it did before because the pixmap has already been
scaled at that point now.

Martin