Re: search branch merged

[Luca Ferretti <elle uca libero it>]

Il giorno mar, 13/12/2005 alle 15.52 +0100, Alexander Larsson ha
scritto:
> > > 
> > > * Need an icon for search folders
> > 
> > Isn't better add a "search" emblem and use it over a plain desktop icon
> > then use a custom icon for search folders? As well as the ~/Desktop
> > directory
> 
> emblems are so overused for a multiple of things, and not always shown.
> I think it makes more sense to have a solid new "type", which means a
> separate icon.

See my other post on this thread

> > > * I want some HIG-knowlegable people to go over the new widgetry and
> > >   fix all the padding/alignment etc. I'm pretty bad at these things.
> > 
> > See the attached glade (I tried only the spatial without beagle). Maybe
> > I should check better on HIG, but it seems good to me. In short:
> > 
> >       * 6 px border for search widgets' container
> >       * 12 px, vertical, between search text entry and search combo
> >         boxes (different role)
> >       * 6 px between "Search for" label and text entry (not sure, it
> >         could be 12 in HIG...)
> >       * 12 px between combo boxes

the latest 12 pixels were horizontally, of course.

> 
> That ends up using a *lot* of space though. And the search editor is
> already taking up a lot of space.

Well, we could reduce to a half the border and vertical spacing between
comboboxes. 

>  I'm not sure why, but the glade file
> shows the combo box as much taller than when what nautilus shows.

A theme issue? Or maybe you are using the old deprecated widget ;-) ?

> > Moreover
> >       * add tooltips (see glade)
> >       * the Go button is really ugly :-(
> 
> Its not there if you have an indexed backend like beagle. Then searches
> are "instant apply". 
> 
> I don't know if the reload icon is perfect here. It strikes me more like
> redoing the old search rather than applying your new changes.

Maybe "Find Now" label? Dunno..


> >       * do we really need the blue background??? It could at least
> >         follow the theme color...
> 
> Its possible to theme the color used. I think its a nice way to show
> that this is a special form of location, and not a standard toolbar.
> 

Why don't grab the color from the gtk+ theme? For example the
bg[SELECTED]