Re: search branch merged

[Alexander Larsson <alexl redhat com>]

On Tue, 2005-12-13 at 09:18 +0100, Luca Ferretti wrote:
> Il giorno lun, 12/12/2005 alle 19.58 +0100, Alexander Larsson ha
> scritto:
> > Today I merged the nautilus-search2 branch to HEAD. The code is not
> > totally done yet but it should mostly work, and I wanted to get
> > it into the 2.13.3 so some people would look at it. Also, the branch
> > contained various memleak and other fixes that I wanted to get in.
> > 
> > * Need an icon for search folders
> 
> Isn't better add a "search" emblem and use it over a plain desktop icon
> then use a custom icon for search folders? As well as the ~/Desktop
> directory

emblems are so overused for a multiple of things, and not always shown.
I think it makes more sense to have a solid new "type", which means a
separate icon.

> > * I want some HIG-knowlegable people to go over the new widgetry and
> >   fix all the padding/alignment etc. I'm pretty bad at these things.
> 
> See the attached glade (I tried only the spatial without beagle). Maybe
> I should check better on HIG, but it seems good to me. In short:
> 
>       * 6 px border for search widgets' container
>       * 12 px, vertical, between search text entry and search combo
>         boxes (different role)
>       * 6 px between "Search for" label and text entry (not sure, it
>         could be 12 in HIG...)
>       * 12 px between combo boxes

That ends up using a *lot* of space though. And the search editor is
already taking up a lot of space. I'm not sure why, but the glade file
shows the combo box as much taller than when what nautilus shows.

> Moreover
>       * add tooltips (see glade)
>       * the Go button is really ugly :-(

Its not there if you have an indexed backend like beagle. Then searches
are "instant apply". 

I don't know if the reload icon is perfect here. It strikes me more like
redoing the old search rather than applying your new changes.

>       * It could be interesting add an icon on file type selector (see
>         tango icons)

Maybe.

>       * do we really need the blue background??? It could at least
>         follow the theme color...

Its possible to theme the color used. I think its a nice way to show
that this is a special form of location, and not a standard toolbar.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a suicidal shark-wrestling matador haunted by memories of 'Nam. She's a 
strong-willed red-headed snake charmer living on borrowed time. They fight 
crime!