Re: [PATCH] gnome-vfs: Don't monitor read-only filesystems

[Alexander Larsson <alexl redhat com>]

On Wed, 2004-04-07 at 12:08, Frederic Crozat wrote:
> Le mer 07/04/2004 à 11:59, Alexander Larsson a écrit :
> > On Wed, 2004-04-07 at 11:10, Frederic Crozat wrote:
> > > Le mer 07/04/2004 à 10:55, Alexander Larsson a écrit :
> > > > On Mon, 2004-04-05 at 11:41, Frederic Crozat wrote:
> > > > > I was just wondering what was the status of this patch ?
> > > > > 
> > > > > It doesn't seem to have been pushed in 2.6.
> > > > 
> > > > No, but similar code is already in Nautilus [see
> > > > nautilus-monitor.c:monitor_add_internal()]. I'm not sure putting it in
> > > > gnome-vfs for all monitor uses is a good idea. It imposes a quite heavy
> > > > performance hit (stat per monitor + need to connect to the daemon for
> > > > the volume monitor) for things that rarely need this. And it doesn't
> > > > even really "solve" anything. If an app leaves monitors around it'll
> > > > still mean you can't unmount the volume, and this needs fixing anyway.
> > > 
> > > Well, it is still a problem because of monitoring on recent-files :
> > > -try to run an audio file from a CDROM with totem
> > > -the file will be added to recent-files and will be monitored.
> > > -therefore, you won't be able to eject the CD, unless fam is killed..
> > 
> > Until the broken app that used the broken recent-files is killed you
> > mean.
> 
> No, killing fam was enough.. Fam was maintaining an open fd on the cdrom
> drive. Killing it allows unmounting the drive.

Killing fam was enough? Thats like saying "its not an app fault, killing
the kernel was enough to fix it". Fam does work on behalf of its
clients, if one of the clients asks fam to monitor a directory it will
do that, until the app says not to or the app dies. That fam monitors
the directory is *not* the fault of fam, but of the app. Killing fam
breaks monitoring for all apps that are currently connected to it.
Killing just the app that monitors the thing blocking unmount fixes the
unmount problem.

> Anyway, my tests were based on 2.4 stuff, I need to try it again with
> 2.6.

I know we (rh) had to patch out some of the recent-files monitoring due
to it being egg stuff and not everyone updating to the latest.

> > > And I haven't yet tested with removable drives (usb storage, memory
> > > sticks) which have similar issues.
> > 
> > Yes, and as I said above, this patch will *not* work for them. The only
> > solution is to fix the damn apps that locks up the drives.
> 
> Ok.. Then we'll have to fix nautilus, since I had these kind of problem
> with nautilus 2.4 (not tested with 2.6 yet) :)))

There *was* an actual fam problem that made it lose track of monitors
which caused unmount blocking that *required* you to kill fam (killing
all clients wasn't enough). However, I fixed that bug, and I don't think
there are more of them.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a war-weary umbrella-wielding messiah looking for a cure to the poison 
coursing through his veins. She's a cosmopolitan snooty soap star fleeing from 
a Satanic cult. They fight crime!