Re: [PATCH] gnome-vfs: Don't monitor read-only filesystems

tt de Le ven 06/02/2004 à 14:43, Alexander Larsson a écrit :
> On Mon, 2004-01-26 at 17:13, John McCutchan wrote:
> > On Mon, Jan 26, 2004 at 09:18:54AM +0100, Alexander Larsson wrote:
> > > Hmmm. Nautilus already does this. However, there was a race condition on
> > > mount which made this not always work, which i fixed last week.
> > > 
> > > Maybe the check makes more sense in gnome-vfs than nautilus though,
> > > since other apps can monitor stuff. I'm not sure about returning an
> > > error though. Nautilus just makes a monitor that never signals any
> > > change.
> > 
> > I think it makes more sense in gnome-vfs, the recent-files stuff
> > monitors all files in the list, which causes problems when unmounting
> > cdroms. I am not that familiar with gnome-vfs code, what result should
> > the code return in this situation?
> It should succeed and never send any change events. Thats the same
> semantics as now, only using less effort and not hogging the cdrom. Of
> course, this adds an extra couple of stats to each monitor, so monitor
> creation performance is down.

I was just wondering what was the status of this patch ?

It doesn't seem to have been pushed in 2.6.

Frederic Crozat <fcrozat mandrakesoft com>

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]