Re: [PATCH] Fix CRLF handling

[Kai <kai willadsen gmail com>]

On 6 June 2010 18:37, Piotr Piastucki <leech miranda gmail com> wrote:
> Hi,
>
> I use Ubuntu 10.4 and it includes the following packages:
> libgtk 2.20.1
> python 2.6.5
> python-gtksourceview2 2.10.1
>
> All this stuff seems to be quite up-to-date.
>
> Do you want me to provide more info?

So I've finally been able to reproduce this bug, but only by opening
files without universal newline support (i.e., I removed "U" from the
open calls in filediff.py). I'm not sure whether this is a bug in
Python's universal newline support, or a distribution bug. However,
it's not limited to Ubuntu (see for example
https://bugzilla.gnome.org/show_bug.cgi?id=623076) so I think we need
to work around it.

I'll take another look at this patch soon.

cheers,
Kai

> On 06/05/2010 11:55 PM, Kai Willadsen wrote:
>>
>> On 1 June 2010 16:41, Piotr Piastucki<leech miranda gmail com>  wrote:
>>
>>>
>>> Hi,
>>>
>>> Here is another version of the fix.
>>> Unfortunately, set_text() approach results in scrollbar flickering and it
>>> is
>>> much slower.
>>>
>>
>> Yeah, I found this out shortly after I suggested it.
>>
>> The new patch looks good, though there should definitely be a comment
>> explaining what is going on; it's an odd looking piece of code after
>> all. I can add this myself.
>>
>> However, while I swear I saw the problem before, I now can't reproduce
>> the original bug. I'm trying to figure out whether this is an issue
>> with sourceview/textbuffer and for the life of me I can't actually get
>> the incorrect line breaking to occur. What are the versions of
>> (python/gtk/gtksourceview/etc.) that you see this with?
>>
>> cheers,
>> Kai
>>
>
>