Re: [PATCH] Fix CRLF handling

[Kai <kai willadsen gmail com>]

On 11 July 2010 12:28, Kai <kai willadsen gmail com> wrote:
> On 6 June 2010 18:37, Piotr Piastucki <leech miranda gmail com> wrote:
>> Hi,
>>
>> I use Ubuntu 10.4 and it includes the following packages:
>> libgtk 2.20.1
>> python 2.6.5
>> python-gtksourceview2 2.10.1
>>
>> All this stuff seems to be quite up-to-date.
>>
>> Do you want me to provide more info?
>
> So I've finally been able to reproduce this bug, but only by opening
> files without universal newline support (i.e., I removed "U" from the
> open calls in filediff.py). I'm not sure whether this is a bug in
> Python's universal newline support, or a distribution bug. However,
> it's not limited to Ubuntu (see for example
> https://bugzilla.gnome.org/show_bug.cgi?id=623076) so I think we need
> to work around it.
>
> I'll take another look at this patch soon.

I've just pushed this patch with some added explanatory comments.

cheers,
Kai