Re: rfc: find dialog replaced with findbar

[Stephen Kennedy <stevek gnome org>]

Kai:
> Looks like a nice change. The only thing is that I think it could
> generally act a bit more like other find bars, use similar strings,
> etc. I guess this means use "Find:" instead of "Search for", have
> "Find Next" and "Find Previous" buttons, and don't have a close
> button, but just close when the bar loses focus.

What other apps have a find bar? I took the main idioms from firefox
Ctrl+F search which stays until closed - either with the button or with
Escape. You think it should behave more like the quickfind "/"?

The "search for" etc labels are a little annoying because of the accelerators:
_Find clashes with _File from the menu. I ended up taking the strings
from the gedit search/replace dialog, but am open to suggesions. We could
just remove the accelerators entirely but I find them handy to jump to
the entries after changing options.

Vincent:
> - highliting of found text does not always work, and it's not always
> at the same place that it works or not

Can you explain a little more? How can I reproduce the bug?

Thanks for the feedback guys, I've fixed the most glaring (and easy!)
bugs. There's still a way to go, but already I think it's better than before.
As a reminder to self, I've listed the items in
http://bugzilla.gnome.org/show_bug.cgi?id=362528

Remove popup dialogs - use a different notification of errors.
  Status label? Web-like tooltip popup?
Implement find previous
Implement replace all
Use history entry
Prefill entries with selected text, etc

Regards,
Stephen.