Re: Current trunk broken for mercurial

[Vincent Legoll <vincent legoll gmail com>]

On Tue, Mar 10, 2009 at 5:06 PM, Vincent Legoll
<vincent legoll gmail com> wrote:
> The message has been fixed to be more informative, but I can reproduce
> the original bug, which is not mercurial specific, I get the same problem
> with at least git & hg for files not directly located in Vc.root, i.e. all files
> that are in subdirectories... I have a workaround, but I don't know what
> else would it break.
>
> But svn seems immune, which might explain why that bug slipped in...

were affected: git, hg, darcs, bzr, monotone
tested fixed, or not broken: git, hg, bzr, monotone
still broken: darcs - to investigate separately
not tested: tla, cvs - no test setup

Please test & comment on the attached patch.

> Are there automated regression tests for meld ?
> I've seen traces, but not the best itself...

I'm working on something...

> I have another fix for monotone too. I'll sent those this evening.

Committed in r1250, as semi-obvious. Every other VC that does
this kind of thing has a way of specifying the repository path or
goes into it beforehand...

-- 
Vincent Legoll

Index: vcview.py
===================================================================
--- vcview.py	(revision 1249)
+++ vcview.py	(working copy)
@@ -451,7 +451,7 @@
 
             if not os.path.exists(destdir):
                 os.makedirs(destdir)
-            pathtofile = os.path.join(prefix, fname)
+            pathtofile = os.path.join(prefix, os.path.basename(fname))
             try:
                 shutil.copyfile( pathtofile, destfile)
             except IOError: # it is missing, create empty file