Re: Patches to review
- From: "Stephen Kennedy" <stevek gnome org>
- To: "Vincent Legoll" <vincent legoll gmail com>
- Cc: meld-list gnome org
- Subject: Re: Patches to review
- Date: Tue, 18 Mar 2008 08:11:56 +0000
> > This is an old horse but I once created a patch to open new files in
> > tabs of existing meld instances, using dbus of all things.
> > One of the original posts is here
> > http://mail.gnome.org/archives/meld-list/2007-July/msg00015.html
> > and the bug concerning it is here
> > http://bugzilla.gnome.org/show_bug.cgi?id=453670
Thanks for your patience Kacper, I feel pretty bad about leaving it so long.
> Maybe Stephen can tell us what should be modified so that the patch could
> be submitted in svn...
Well, one of the things meld is used for is three way merging. e.g. mercurial
can spawn meld when it needs human help. One problem with this is that meld
can't return a useful exit status to say whether the merge was successful or
aborted so scripts have to rely on the heuristic that if the merge
file was saved,
everything is ok. This is a bit fragile if you have a complex merge and you want
to save progress!
I'd love to see a "blocking" meld dbus interface which could spawn a diff tab
and wait for the tab to be closed. There could be a "mark resolved" button
or the user could be prompted on close whether the merge succeeded.
Also, I wonder how do dbus apps deal with multiple instances? Does the first one
simply take the dbus connection? I'd like to see some way of communicating with
] [Thread Prev