Re: undelfs warnings fix

On Mon, 17 Nov 2003, Andrew V. Samoilov wrote:

> > On Fri, 14 Nov 2003, Andrew V. Samoilov wrote:
> >
> > > Previous patch implementation breaks mcfs compilation, and as I understood
> > > recently current implementation of com_err() is wrong and have format string
> > > vulnerability.
> > >
> > > New implementation fixes com_err() and does not define free, sorry about
> > > glib and libc memory allocation function mix, but we have it for glib 1.2x.
> > > already.
> >
> > Applied.  Thank you!  The mix is unavoidable, but glib 1.2.x always uses
> > libc memory allocation.
> Thanks! I hope this is last iteration for com_err() - va_list
> must be first local variable in function, now call to com_err() hangs mc.
> Sorry for lack of testing.

I cannot find any document that says so.  However, everybody puts va_list
first, so maybe there is a reason for that.  Strange that nobody
complained about message() in CVS.  I'm applying your patch, but I'll
appreciate if you post a document saying that va_list should be first.

Pavel Roskin

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]