Re: undelfs warnings fix

["Andrew V. Samoilov" <andrew email zp ua>]

> On Fri, 14 Nov 2003, Andrew V. Samoilov wrote:
> 
> > Previous patch implementation breaks mcfs compilation, and as I understood
> > recently current implementation of com_err() is wrong and have format string
> > vulnerability.
> >
> > New implementation fixes com_err() and does not define free, sorry about
> > glib and libc memory allocation function mix, but we have it for glib 1.2x.
> > already.
> 
> Applied.  Thank you!  The mix is unavoidable, but glib 1.2.x always uses
> libc memory allocation.
 
Thanks! I hope this is last iteration for com_err() - va_list 
must be first local variable in function, now call to com_err() hangs mc.
Sorry for lack of testing.

-- 
Regards,
Andrew V. Samoilov.

--- undelfs.c	Mon Nov 17 16:50:00 2003
+++ undelfs.c~	Mon Nov 17 16:48:57 2003
@@ -281,8 +281,8 @@ undelfs_loaddel (void)
 void
 com_err (const char *whoami, long err_code, const char *fmt, ...)
 {
-    char *str;
     va_list ap;
+    char *str;
 
     va_start (ap, fmt);
     str = g_strdup_vprintf (fmt, ap);

--- vfs/ChangeLog~	Mon Nov 17 15:31:05 2003
+++ vfs/ChangeLog	Mon Nov 17 17:45:09 2003
@@ -171,7 +171,7 @@
 
 	* vfs.h: Remove redundant declaration of init_localfs().
 
-	* mcserv.c: Don't use HAVE_CRYPT from extraonf.h.
+	* mcserv.c: Don't use HAVE_CRYPT from extraconf.h.
 	* samba/include/includes.h: Likewise.
 
 2003-10-24  Pavel Roskin  <proski gnu org>