Re: gtksourceviewmm 3.12

[Krzesimir Nowak <qdlacz gmail com>]

2015-05-10 18:43 GMT+02:00 Christoph Brill <egore911 gmail com>:
> Btw: I created some pull requests at
> https://github.com/GNOME/gtksourceviewmm/pulls ... can someone please review
> the code and give me some feedback whether or not I'm doing the right thing?

Hi Christoph,

Thanks for the code.

We usually don't use github PR for contributions, but meh - I won't
gripe about it. I only skimmed the code, I haven't built it or
anything. Few remarks:
1. Please don't add gmmproc-generated header and source files to git.
2. There is a newline at the end of file missing in searchcontext.ccg
and searchsettings.ccg.
3. Make sure that class doxycomments are correct (e.g. they are
relevant to wrapped class, they mention C++ classes instead of C ones,
and so on).
4. Make sure @newin denote a version of gtksourceviewmm version which
really got the API (so API in search context would be 3.16)


> Christoph Brill <egore911 gmail com> schrieb am So., 10. Mai 2015 um 18:40
> Uhr:
> > Real good pointer. I actually wonder how bad my google foo must have been
> > messed up this morning... Thanks a lot for pointing these out!
> >
> > Kjell Ahlstedt <kjell ahlstedt bredband net> schrieb am So., 10. Mai 2015
> > um 16:46 Uhr:
> > > Have you seen the appendix "Wrapping C Libraries with gmmproc" in the
> > > gtkmm tutorial?
> > >
> > > https://developer.gnome.org/gtkmm-tutorial/stable/chapter-wrapping-c-libraries.html.en
> > >
> > > mm-common contains a skeleton project with a script file that (after some
> > > modification) can generate the 4 files xxx_docs.xml, xxx_enum.defs,
> > > xxx_method.defs and xxx_signal.defs.
> > >
> > > https://git.gnome.org/browse/mm-common/tree/skeletonmm/codegen/generate_defs_and_docs.sh
> > >
> > >
> > > Kjell
> > >
> > > Den 2015-05-10 09:48, Murray Cumming skrev:
> > >
> > > On Sun, 2015-05-10 at 09:23 +0200, Christoph Brill wrote:
> > >
> > > 1.) Regenerate the method.defs files
> > > I'm using h2def.py from glibmm on the sources of gtksourceview 3.12.3.
> > > So far I managed to regenerate the methods using the following
> > > command:
> > >
> > >
> > > $ ../glibmm/tools/defs_gen/h2def.py ../gtksourceview/gtksourceview/ >
> > > gtksourceview/src/gtksourceview_methods.defs
> > >
> > >
> > >
> > > 2.) Regenerate the signals.defs files
> > > From my understanding this contains the signals and properties, but I
> > > have no clue on how to generate this. Any hints welcome!
> > >
> > > The more active *mm projects now have helpful little gen_scripts/*.sh
> > > scripts to make this easier:
> > > https://git.gnome.org/browse/gtkmm/tree/tools/gen_scripts
> > >
> > > You'll probably want to create them for gtksourceiewmm too.
> > >
> > > Nobody will mind if you need to "git mv" some stuff around to make it
> > > more consistent, as long as you update the build flies appropriately
> > > where necessary.
>
> _______________________________________________
> gtkmm-list mailing list
> gtkmm-list gnome org
> https://mail.gnome.org/mailman/listinfo/gtkmm-list