Re: Toolbar->append_element()

[goran kirra net]

My state of mind:
Refactoring is a good thing, it produces better code.

BUT we need a regression test,
I am sure that when new function and classes get added
people do because they need it to runs some code,
but I seldom see any testcases checked in.

This means that code WILL break and we will not know it.
PLS check in small test cases/examples running all new
functions/classes added in the Gtk2 class hierarchy.

/göran


On Tue, Nov 05, 2002 at 01:18:31PM +0100, Christian Borup wrote:
> On tir, 2002-11-05 at 13:14, Guillaume Cottenceau wrote:
> > Guillaume Cottenceau <gc mandrakesoft com> writes:
> >
> > > > I don't think I'm guilty of that yet... But would you post short howto?
> > > > For enums you haven't allready made macros for that is?
> > >
> > > Hum, yes of course, there are macros :). Check all that contains
> > > "perl_gtk2_convert_enum" in Gtk2/include/*.h, for example.
> >
> > Of course, these could also be replaced by an appopriate typemap
> > (but maybe this is a bit late considering the codebase and the
> > needed mess to do the change - especially with the handy
> > genscripts/convert_funcs.pl).
>
> A lot of cleaning up will have to be done at some point anyway. And it
> could be done incrementaly...
>
> ./borup