Re: [gtk-osx-users] New build system.

Le 15 avr. 2019 à 11:53, Pascal <p p14 orange fr> a écrit :

Thanks John for the tip.

One remark on last
lines 218-223: if XDG_CONFIG_HOME and $HOME/.config and $HOME/.jhbuildrc don't exist then config_dir and 
jhbuildrc_file remain empty thats may be an issue lines 234 and 238.
Line 223 I would add:
      else mkdir $HOME/.config; config_dir="$HOME/.config";

Hello John, few more comments on
I ran it with:
$ DEVROOT=$xnadainst PIP_CONFIG_DIR=$xnadainst/.config/pip XDG_CONFIG_HOME=$xnadainst/.config sh
(xnadainst is set to my external volume)

- But I haven't pip in xnadainst then I've got this error:
.new_local/bin/pip: No such file or directory
My configuration is:
$ python --version
Python 2.7.10
$ python -m ensurepip --user
Ignoring indexes:
Requirement already satisfied (use --upgrade to upgrade): setuptools in /Library/Python/2.7/site-packages
Requirement already satisfied (use --upgrade to upgrade): pip in /Library/Python/2.7/site-packages
==> this doesn't install pip

What is test line 88 "if test $mv -lt 9 ; then" for ?
I've changed it with 11, not sure it is correct.

- Later I got the error: line 241: unexpected EOF while looking for matching `"'
I've added quotes.

- I've updated also the script name in comments line 3

- I've changed the BASEURL t to catch new jhbuildrc and jhbuildrc-custom.

I've made a pull request:

NB: I haven't made a fix for previous remark on the top of this message, what is your feedback?

HTH, Pascal.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]