Re: GtkPlug/Socket on Win32: is_focus vs. is-focus

On Tue, 2005-03-22 at 03:12 +0200, Tor Lillqvist wrote:
> In gtksocket.c, we have:
> static void
> gtk_socket_notify (GObject    *object,
> 		   GParamSpec *pspec)
> {
>   if (!strcmp (pspec->name, "is_focus"))
>     return;
>   socket_update_focus_in (GTK_SOCKET (object));
> }
> Shouldn't that be "is-focus"? That is what the function actually gets
> called with. Not that it seems to matter on X11. And not on Win32
> either, sigh.

Yes, it should be "is-focus". The names of paramspecs are canonicalized
when registering them, so even if it got registered with "is_focus",
pspec->name will be "is-focus".

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]