Re: [PATCH 0/9] Add references counter to GrlMediaSourceFooSpec structures

["Juan A. Suarez Romero" <jasuarez igalia com>]

On Mon, 2010-07-19 at 09:13 +0200, Iago Toral wrote:
> About all those access macros you created for the Spec structures,
> shouldn't 
> we patch the plugins to use them as well? After all, they are the ones
> using 
> the structs the most :)

Well, actually adding getters/setters is a bit offtopic of the main goal
of the patches, but still I found having them important, so I added them
just to know your opinion.

In fact, the right way would be hiding the fields and provide access
only through the set/get methods. This is, at least, how GHashTable
does. What do you think? If agree, I'll do it and patch plugins.


> 
> Also, you have to add documentation for all those new APIs and macros.

Yes, I need to add it.

> One thing that bothers me a little is the fact that all that stuff is
> only useful 
> for core & plugins developers, but not for application developers, I
> guess when 
> we add the docs we should take this into account so people know what
> APIs are 
> for application developers and what APIs are for plugin developers. 

Yeah, I agree. Actually I find sometimes a bit messy having all
functions in same place. Not sure if it would be better to split
functions in two groups, those useful for applications developers
(grilo.h) and those intended for plugins developers (grilo-plugin.h)

	J.A.