Re: [PATCH 7/9] core: Protect browse/search/query specs before invoking source operation



On Mon, 2010-07-19 at 09:19 +0200, Iago Toral wrote:
> This patch has a bug (in the search method you ref/ref instead of
> ref/unref).
> 

Thanks, I'll fix it.

> Also, implementation of virtual methods can be async, however, you
> always unref 
> after invoking the method, is that alright?
> 

Yes, and now you're mentioning it, I need to review some doubts that
come up to my mind regarding this issue. I'll check them before pushing.


	J.A.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]