Re: [PATCH 0/9] Add references counter to GrlMediaSourceFooSpec structures



El lun, 19-07-2010 a las 10:20 +0200, Juan A. Suarez Romero escribió:
> On Mon, 2010-07-19 at 09:13 +0200, Iago Toral wrote:
> > About all those access macros you created for the Spec structures,
> > shouldn't 
> > we patch the plugins to use them as well? After all, they are the ones
> > using 
> > the structs the most :)
> 
> Well, actually adding getters/setters is a bit offtopic of the main goal
> of the patches, but still I found having them important, so I added them
> just to know your opinion.
> 
> In fact, the right way would be hiding the fields and provide access
> only through the set/get methods. This is, at least, how GHashTable
> does. What do you think? If agree, I'll do it and patch plugins.

Yes, that would be the right thing to do.

Iago



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]