Re: [PATCH 0/9] Add references counter to GrlMediaSourceFooSpec structures

[Iago Toral <itoral igalia com>]

On Thu, 15 Jul 2010 08:57:14 +0200, "Juan A. Suarez Romero"
<jasuarez igalia com> wrote:
> On Tue, 2010-07-13 at 09:33 +0200, Iago Toral wrote:
>> I still did not have time to review this.
> 
> Summarizing it for the record: it adds to MediaSpecs _ref() and _unref()
> function, keeping these specs as structs, as in GHashTable case.
> 
> So when plugin invokes callback with remaining==0, spec is not destruyed
> inmediately, but after the plugin function returns. Still, plugin can
> prevent this destruction by reffing the spec.

I skimmed through your patches quickly because unfortunately I don't have much 
time these days and I don't want to hold this too long for that reason only. 
Anyway, I liked the idea and I did not see any obvious issue with the patches.

About all those access macros you created for the Spec structures, shouldn't 
we patch the plugins to use them as well? After all, they are the ones using 
the structs the most :)

Also, you have to add documentation for all those new APIs and macros.

One thing that bothers me a little is the fact that all that stuff is only useful 
for core & plugins developers, but not for application developers, I guess when 
we add the docs we should take this into account so people know what APIs are 
for application developers and what APIs are for plugin developers.

Iago