GNOME.org

Re: [PATCH] Allow to shrink dialogs to just display a single GnumericExprEntry

From: "Morten Welinder" <mwelinder gmail com>
To: "Christian Neumair" <chris gnome-de org>
Cc: gnumeric-list gnome org
Subject: Re: [PATCH] Allow to shrink dialogs to just display a single GnumericExprEntry
Date: Thu, 1 Jun 2006 15:16:49 -0400

I haven't actually tried it, but from just looking at it...

1. We don't want g_assert calls.  It seems this should be able to fail
  gracefully by just not doing anything.

2. If "container_props" ends up as NULL, I think you will end up calling
  g_value_array_free on it.  That's not allowed.

M.

Follow-Ups:
- Re: [PATCH] Allow to shrink dialogs to just display a single GnumericExprEntry
  - From: Christian Neumair

References:
- [PATCH] Allow to shrink dialogs to just display a single GnumericExprEntry
  - From: Christian Neumair

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]