Re: [PATCH] Allow to shrink dialogs to just display a single GnumericExprEntry

[Christian Neumair <chris gnome-de org>]

Am Donnerstag, den 01.06.2006, 15:16 -0400 schrieb Morten Welinder:
> 1. We don't want g_assert calls.  It seems this should be able to fail
>    gracefully by just not doing anything.

I think whenever one of my g_asserts doesn't hold, something really bad
happened which demands for a bug report. Maybe HACKING should clearly
state what the g_assert / g_return_if_fail policy is.

> 2. If "container_props" ends up as NULL, I think you will end up
> calling
>    g_value_array_free on it.  That's not allowed. 

Good catch. g_object_set_data_full uses a NULL destroy notify for NULL
data, though. Because the docs don't state that, I filed a bug report
against glib [1].

[1] http://bugzilla.gnome.org/show_bug.cgi?id=343750

-- 
Christian Neumair <chris gnome-de org>