On Fr, 2005-11-04 at 11:53 +0100, Jean Bréfort wrote:
Le vendredi 04 novembre 2005 à 11:44 +0100, Christian Neumair a écrit :On Fr, 2005-11-04 at 07:55 +0100, Jean Bréfort wrote:Le jeudi 03 novembre 2005 à 22:42 +0100, Christian Neumair a écrit :On Mi, 2005-11-02 at 16:58 +0100, Jean Bréfort wrote:I have one objection against the goffice patch: the changes in go-graph-widget.c are much too large. This widget was devised to be used in other apps, and do part of the job on initialization (create a graph with a chart and the renderer). It looks like a complete rewrite. I would prefer a new widget, or add a go_graph_widget_set_graph function if we want to change the default graph.Updated according to your suggestions on IRC. Do you insist on the chart getters/setters? This patch still doesn't include them.It would be nice (at least get), because it is one less step for clients which need only one chart.New proposed patch, which also fixes refcounting for widget-constructed graphs and the some return_if_fail statements.No more objections :-)
Thanks. Attaching a new version which even doesn't break GO_GRAPH_WIDGET_REFERENCE_DIRECTION_VERTICAL. -- Christian Neumair <chris gnome-de org>
Attachment:
goffice-graph-widget-4.diff
Description: Text Data
Attachment:
signature.asc
Description: This is a digitally signed message part