Re: [PATCH] add graph window



Le jeudi 03 novembre 2005 à 22:42 +0100, Christian Neumair a écrit :
On Mi, 2005-11-02 at 16:58 +0100, Jean Bréfort wrote:
I have one objection against the goffice patch: the changes in
go-graph-widget.c are much too large. This widget was devised to be used
in other apps, and do part of the job on initialization (create a graph
with a chart and the renderer). It looks like a complete rewrite. I
would prefer a new widget, or add a go_graph_widget_set_graph function
if we want to change the default graph.

Updated according to your suggestions on IRC. Do you insist on the chart
getters/setters? This patch still doesn't include them.

It would be nice (at least get), because it is one less step for clients
which need only one chart.

You are right that it introduces some new codepaths. However, it was
written to not break old client apps semantically. pie-demo still seems
to work as expected.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]