Re: Code tidy up in GNOME Control Center

[Bastien Nocera <hadess hadess net>]

On Fri, 2017-09-22 at 02:03 +0000, Robert Ancell wrote:
> Hi all,
>
> I'm interested in modernising some of the GObject code in G-C-C and
> wanted to check no one is opposed to it / give a heads up.
>
> In particular, I plan to do the following:
<snip>
> - Fix up inconsistent whitespace usage (currently I see 2/4/8 spaces
> and tabs all mixed together) - lower priority.

Good, but fixing indentation is absolutely not useful, unless you're
restarting a new project from scratch. I would avoid doing that.

<snip>
> I've got a branch (wip/rancell/g-define-type) that replaces all the
> old GObject macros with G_DEFINE_*_TYPE which should give you some
> idea of the sort of changes.
>
> If no opposition, I plan to commit these changes per-panel (probably
> simpler panels before the more complex ones). Please let me know if
> there's any panels that someone is working on that I should avoid /
> do later.

Unless Rui has put something else in place, patches still need
reviewing in Bugzilla. Use git-bz.

Cheers