Re: Code tidy up in GNOME Control Center

[Rui Tiago Cação Matos <tiagomatos gmail com>]

Hi,

Robert already contacted me before so he knows I'm generally for this.
The only question is mostly of timing. I think we're close to land a
search panel re-design by Felipe so let's aim for after that branch
lands.

More specific comments inline below.

On Fri, Sep 22, 2017 at 4:03 AM, Robert Ancell <robert ancell gmail com> wrote:
> - Get the panel code more consistent between panels.
> - Use modern boilerplate GObject code (i.e. G_DEFINE_*_TYPE).

Good, thanks for doing this!

> - Use g_auto macros where possible to make code simpler and reduce memory
> leaks (much easier when using G_DEFINE_*_TYPE).

I guess that's your intention already but just to be clear, these
should be separate patches.

> - Use more modern GtkBuilder integration.

Likewise, separate patches and per panel.

> - Fix up inconsistent whitespace usage (currently I see 2/4/8 spaces and
> tabs all mixed together) - lower priority.

This one I wouldn't bother. It's a lot of code movement for little
(none IMHO) gain.

> If no opposition, I plan to commit these changes per-panel (probably simpler
> panels before the more complex ones). Please let me know if there's any
> panels that someone is working on that I should avoid / do later.

Like I said above, at least for the search panel, please wait for
Felipe's branch to land.

Thanks,
Rui