Re: Display configuration capplet

[Bryce Harrington <bryce canonical com>]

Attached is a patch that keeps the monitor manufacturer lists separate.
I also added the source URL and some additional companies they listed so
we now have everything from that URL.

Bryce

On Wed, Feb 27, 2008 at 11:17:31AM -0800, Bryce Harrington wrote:
> On Wed, Feb 27, 2008 at 07:45:32PM +0100, Soeren Sandmann wrote:
> > Bryce Harrington <bryce canonical com> writes:
> > 
> > > On Wed, Feb 27, 2008 at 03:17:03AM +0100, Soeren Sandmann wrote:
> > > > > I've mostly been focusing on packaging the existing code this last week
> > > > > but will try to contribute some time to it.  I hope it's ok if I just
> > > > > send you patches here.
> > > > 
> > > > Certainly.
> > > 
> > > I noticed my monitor is missing from display-name.c (BenQ); attached is
> > > a patch to add it.  Also, I googled a bit and found a page with a
> > > listing of EDID Manufacturer ID's - mine was not on it, but it contained
> > > a number of other common monitors not already in display-name.c.
> > 
> > Out of curiousity, where did you find this? I googled for it too, but
> > didn't find anything. 
> 
> I found it at:
>   http://faydoc.tripod.com/structures/01/0136.htm
> 
> > The list I had was based on some code I found on sourceforge. It had
> > some incorrect entries, so I don't trust it completely.
> 
> Yeah, I also ran across a couple other pages with TLA->Company mappings
> (one from a milspec) but only some of the names mapped correctly.  The
> above link is from an EDID spec document, so it seems the most
> authoritative source I could find.
> 
> I notice display-name.c has the labels separated by source, which I
> think is a very good idea - it may help in the future if we notice
> incorrect entries to be able to go back and re-review.  I'd like to
> suggest including the source for each set of entries, for future
> reviewers.
> 
> 
> Btw, I also looked through the MonitorDB, which does not have the
> monitor TLA mappings, but is a useful list of monitor manufacturers.
> With the combined info we have now, I think we've covered the vast bulk
> of these, but there's still a handful of manufacturers we're missing
> (BenQ as an example).  I guess we can keep an eye out for them in bug
> reports.
> 
> Bryce
> 
> 
> 
> _______________________________________________
> gnomecc-list mailing list
> gnomecc-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnomecc-list

diff --git a/display-name.c b/display-name.c
index 82324a8..88697aa 100644
--- a/display-name.c
+++ b/display-name.c
@@ -51,85 +51,57 @@ static const struct Vendor vendors[] =
     { "WAC", "Wacom" },
     { "NEC", "NEC" },
     { "CMO", "CMO" },	/* Chi Mei */
+    { "BNQ", "BenQ" },
 
     { "ABP", "Advansys" },
     { "ACC", "Accton" },
     { "ACE", "Accton" },
-    { "ADI", "ADI Systems" },
     { "ADP", "Adaptec" },
     { "ADV", "AMD" },
     { "AIR", "AIR" },
     { "AMI", "AMI" },
-    { "API", "Acer America" },
-    { "APP", "Apple Computer" },
     { "ASU", "ASUS" },
-    { "AST", "AST Research" },
     { "ATI", "ATI" },
     { "ATK", "Allied Telesyn" },
-    { "ATT", "AT&T" },
     { "AZT", "Aztech" },
     { "BAN", "Banya" },
-    { "BNQ", "BenQ" },
     { "BRI", "Boca Research" },
     { "BUS", "Buslogic" },
     { "CCI", "Cache Computers Inc." },
     { "CHA", "Chase" },
     { "CMD", "CMD Technology, Inc." },
     { "COG", "Cogent" },
-    { "CPL", "Compal" },
     { "CPQ", "Compaq" },
     { "CRS", "Crescendo" },
     { "CSC", "Crystal" },
     { "CSI", "CSI" },
     { "CTL", "Creative Labs" },
-    { "CTX", "CTX" }, /* Chuntex Electronic Co. */
     { "DBI", "Digi" },
     { "DEC", "Digital Equipment" },
     { "DBK", "Databook" },
-    { "DWE", "Daewoo" },
-    { "ECS", "Elitegroup" },
     { "EGL", "Eagle Technology" },
-    { "EIZ", "EIZO" },
     { "ELS", "ELSA" },
     { "ESS", "ESS" },
     { "FAR", "Farallon" },
     { "FDC", "Future Domain" },
-    { "GWY", "Gateway" },
-    { "HEI", "Hyundai" },
     { "HWP", "Hewlett-Packard" },
-    { "HIT", "Hitachi" },
     { "IBM", "IBM" },
-    { "ICL", "Fujitsu ICL" },
     { "INT", "Intel" },
     { "ISA", "Iomega" },
-    { "IVM", "Idek Iiyama" },
-    { "KFC", "KFC Computek" },
-    { "LTN", "Lite-On" },
     { "MDG", "Madge" },
     { "MDY", "Microdyne" },
-    { "MEL", "Mitsubishi Electric" },
     { "MET", "Metheus" },
     { "MIC", "Micronics" },
     { "MLX", "Mylex" },
-    { "NAN", "Nanao" },
-    { "NOK", "Nokia" },
     { "NVL", "Novell" },
     { "OLC", "Olicom" },
-    { "OLI", "Olivetti" },
-    { "OQI", "Optiquest" },
-    { "PBN", "Packard Bell" },
-    { "PGS", "Princeton" },
-    { "PHL", "Philips" },
     { "PRO", "Proteon" },
-    { "REL", "Relisys" },
     { "RII", "Racal" },
     { "RTL", "Realtek" },
-    { "SAM", "Samsung" },
     { "SCM", "SCM" },
     { "SKD", "SysKonnect" },
     { "SGI", "SGI" },
     { "SMC", "SMC" },
-    { "SMI", "Smile" },
     { "SNI", "Siemens Nixdorf" },
     { "STL", "Stallion Technologies" },
     { "SUN", "Sun" },
@@ -139,20 +111,71 @@ static const struct Vendor vendors[] =
     { "TCI", "Tulip" },
     { "TCM", "3Com" },
     { "TCO", "Thomas-Conrad" },
-    { "TAT", "Tatung" },
     { "TEC", "Tecmar" },
     { "TRU", "Truevision" },
     { "TOS", "Toshiba" },
-    { "TSB", "Toshiba" },
     { "TYN", "Tyan" },
     { "UBI", "Ungermann-Bass" },
     { "USC", "UltraStor" },
     { "VDM", "Vadem" },
     { "VMI", "Vermont" },
-    { "VSC", "Viewsonic" },
     { "WDC", "Western Digital" },
-    { "ZCM", "Zenith" },
     { "ZDS", "Zeos" },
+
+    /* From http://faydoc.tripod.com/structures/01/0136.htm */
+    {"ACT", "Targa"},
+    {"ADI", "ADI"},
+    {"AOC", "AOC Intl"},
+    {"API", "Acer America"},
+    {"APP", "Apple Computer"},
+    {"ART", "ArtMedia"},
+    {"AST", "AST Research"},
+    {"CPL", "Compal"},
+    {"CTX", "CTX"  /* Chuntex Electronic Co. */
+    {"DPC", "Delta Electronics"},
+    {"DWE", "Daewoo"},
+    {"ECS", "ELITEGROUP"},
+    {"EIZ", "EIZO"},
+    {"FCM", "Funai"},
+    {"GSM", "LG Electronics"},
+    {"GWY", "Gateway 2000"},
+    {"HEI", "Hyundai"},
+    {"HIT", "Hitachi"},
+    {"HSL", "Hansol"},
+    {"HTC", "Hitachi"},
+    {"ICL", "Fujitsu ICL"},
+    {"IVM", "Idek Iiyama"},
+    {"KFC", "KFC Computek"},
+    {"LKM", "ADLAS"},
+    {"LNK", "LINK Tech"},
+    {"LTN", "Lite-On"},
+    {"MAG", "MAG InnoVision"},
+    {"MAX", "Maxdata"},
+    {"MEI", "Panasonic"},
+    {"MEL", "Mitsubishi"},
+    {"MIR", "miro"},
+    {"MTC", "MITAC"},
+    {"NAN", "NANAO"},
+    {"NEC", "NEC Tech"},
+    {"NOK", "Nokia"},
+    {"OQI", "OPTIQUEST"},
+    {"PBN", "Packard Bell"},
+    {"PGS", "Princeton"},
+    {"PHL", "Philips"},
+    {"REL", "Relisys"},
+    {"SDI", "Samtron"},
+    {"SMI", "Smile"},
+    {"SPT", "Sceptre"},
+    {"SRC", "Shamrock Technology"},
+    {"STP", "Sceptre"},
+    {"TAT", "Tatung"},
+    {"TRL", "Royal Information Company"},
+    {"TSB", "Toshiba, Inc."},
+    {"UNM", "Unisys"},
+    {"VSC", "ViewSonic"},
+    {"WTC", "Wen Tech"},
+    {"ZCM", "Zenith Data Systems"},
+
     { "???", "Unknown" },
 };