Re: finale touches to gtk-engines/gnome-themes before 2.20 release

[Luca Ferretti <elle uca libero it>]

Il giorno dom, 09/09/2007 alle 16.15 +0200, Benjamin Berg ha scritto:
> On Sun, 2007-09-09 at 15:11 +0200, Luca Ferretti wrote: 
> > Hi everyone,
> > 
> > it seems to me there are a couple of tooltips related issue in GNOME
> > themes for 2.20 release. It could be good try to fix them.
> > 
> > 1. New Appearance capplet allow you to customize tooltips color (BG and
> > FG)
> > 
> >         Open Appearance capplet, go to Theme tab, open Details dialog,
> >         go to Color tab: here are 2 color selectors for background and
> >         foreground color of tooltips. Unfortunately those selectory
> >         seems to be grayed for all default GNOME themes.
> >         
> >         I suspect we should update all gtkrc files in order to "unlock"
> >         those buttons. From
> >         gnome-c-c/capplets/appearace/appearace-style.c:
> >         
> >                 static const gchar *symbolic_names[NUM_SYMBOLIC_COLORS]
> >                 = {
> >                   "fg_color", "bg_color",
> >                   "text_color", "base_color",
> >                   "selected_fg_color", "selected_bg_color",
> >                   "tooltip_fg_color", "tooltip_bg_color"
> >                 };
> 
> That would be great, it should not be too much work but needs to be done
> ASAP. The only theme currently using it is Clearlooks. All other themes
> are not yet updated but really should be. I can work on this, but it
> would be great if someone could help. (It is a relative simple change,
> but needs to be done and tested for every theme.)

Here is a patch for Crux (gtk-engines). Colors and code come from
Clearlooks 

Index: themes/Crux/gtk-2.0/gtkrc
===================================================================
--- themes/Crux/gtk-2.0/gtkrc	(revisione 882)
+++ themes/Crux/gtk-2.0/gtkrc	(copia locale)
@@ -29,7 +29,8 @@
 
 # Default style for all widgets to build from
 
-gtk_color_scheme = "fg_color:#000\nbg_color:#c4c6c0\nbase_color:#fff\ntext_color:#000\nselected_bg_color:#75507b\nselected_fg_color:#fff"
+gtk_color_scheme = "fg_color:#000\nbg_color:#c4c6c0\nbase_color:#fff\ntext_color:#000\nselected_bg_color:#75507b\nselected_fg_color:#fff\ntooltip_bg_color:#F
+5F5B5\ntooltip_fg_color:#000"
 
 
 style "default"
@@ -128,3 +129,22 @@
    ythickness = 3
 }
 class "GtkStatusbar" style "statusbar"
+
+style "crux-tooltips"
+{
+        xthickness = 4
+        ythickness = 4
+
+        bg[NORMAL] = @tooltip_bg_color
+        fg[NORMAL] = @tooltip_fg_color
+}
+
+# The window of the tooltip is called "gtk-tooltips"
+################################
+# FIXME:
+# This will not work if one embeds eg. a button into the tooltip.
+# As far as I can tell right now we will need to rework the theme
+# quite a bit to get this working correctly.
+# (It will involve setting different priorities, etc.)
+################################
+widget "gtk-tooltip*" style "crux-tooltips"