Re: Shell 3.26 / GJS Strict Mode settings

[philip chimento gmail com]

On Mon, Oct 9, 2017, 22:19 Jason DeRose <list derose io> wrote:

On Mon, Oct 9, 2017, at 10:38 AM, Emmanuele Bassi wrote:
> GJS is now using an updated mozjs engine, which implements ES6 and
> drop compatibility for Mozilla extensions to the language.
>
> For more information:
>
>   -
>   https://ptomato.wordpress.com/2017/04/22/_javascript_-news-from-gnome-3-24/
>   -
>   https://ptomato.wordpress.com/2017/07/30/modern-_javascript_-in-gnome-guadec-2017-talk/
>
> Ciao,
>  Emmanuele.
>
> --
> https://www.bassi.io
> [@] ebassi [@gmail.com]


Thank you very much for the great links. I think this explains many of
the warnings around exporting from modules, etc.

But I don't get why the warning about testing equality of undefined
variables, which is done all over the shell, is present? Does this need
to actually log a warning? It seems perfectly valid to me.

JS WARNING: [resource:///org/gnome/shell/ui/search.js 636]: reference to
undefined property "searchInProgress"
JS WARNING: [resource:///org/gnome/shell/ui/modalDialog.js 218]:
reference to undefined property "GdkX11Screen"

Hi Jason,

The false positives seemed annoying to me at first, until the warnings actually caught some bugs in my code. Now I appreciate them.

In any case, it's a choice of the JS engine, not of GNOME Shell. You can turn it off on your system with an environment variable, but better just to fix the code so the false positives don't show up.

More info: https://gitlab.gnome.org/GNOME/gjs/blob/master/NEWS#L444

Regards,

Philip C