Re: [gnome-flashback] GNOME Panel improvements

[Balló György <ballogyor gmail com>]

2014-10-17 8:31 GMT+02:00 Alberts Muktupāvels <alberts muktupavels gmail com>:
> On Thu, Oct 16, 2014 at 10:04 PM, Balló György <ballogyor gmail com> wrote:
> > 2014-10-16 19:29 GMT+02:00 Alberts Muktupāvels
> > <alberts muktupavels gmail com>:
> > > > >  2. Use custom menu layout. The official GNOME menu layout adds some
> > > > > additional categories, which may confuse users. Reduce them in our
> > > > > custom menu layout file.
> > > >
> > > >
> > > > It is not that simple as you think...
> > > >
> > > > We patched ubuntu in similar way. Only custom menu file was added to
> > > > gnome-menu package and gnome-panel.desktop file was edited to set
> > > > XDG_MENU_PREFIX. This is only workaround and still does not solve
> > > > problem
> > > > fully. That is way I created this patch -
> > > > https://bugzilla.gnome.org/show_bug.cgi?id=732548.
> > > >
> > > > At least one problem is that Alacarte (menu editing) program will use
> > > > menu
> > > > file XDG_MENU_PREFIX "applications.menu". That means users trying to
> > > > edit
> > > > menu will see different menu from what is available in gnome-panel.
> > > >
> > > > To properly fix this bug we need above patch accepted in gnome-session
> > > > or
> > > > other way to set XDG_MENU_PREFIX for whole session.
> > > >
> > > > I have not tried, but there might be a way to change XDG_MENU_PREFIX
> > > > without above patch:
> > > >
> > > >
> > > > https://git.gnome.org/browse/gnome-session/tree/gnome-session/org.gnome.SessionManager.xml#n8
> > > >
> > > > But then we need application that will be started in initialization
> > > > phase
> > > > and set up XDG_MENU_PREFIX to "gnome-flashback-". gnome-session set it
> > > > to
> > > > "gnome-". If this would work then I would probably do this:
> > > >
> > > > 1) Create new application gnome-flashback-init that will be run in
> > > > initialization phase. At least for now its only task would be to set
> > > > XDG_MENU_PREFIX.
> > > > 2) I would add our custom menu in gnome-flashback module as it was made
> > > > for this - place where to add all missing things for our session. It
> > > > should
> > > > be named gnome-flashback-applications.menu
> > > > 3) Update gnome-panel to use XDG_MENU_PREFIX "applications.menu". This
> > > > way
> > > > file name would not be hardcoded.
> > > >
> > > > I will try this after sending this mail.
> > >
> > >
> > > This should be fixed in gnome-panel wip/gnome-3.10+ and gnome-flashback
> > > master branches. Can you test?
> >
> > It works, thanks! I would prefer if the XDG_MENU_PREFIX would be
> > configurable in gnome-session, but the current solution is fine for
> > me.
>
>
> Why?
>
> This way we will be able to set other environment variables for whole
> session if we will need it. We could add xdg-menu-prefix to flashback
> settings, but is that really needed?

It's not needed. It would be simpler if gnome-session would support it
(until we don't need to set another environment variable).

--
György Balló
Arch Linux Trusted User