Re: [gnome-flashback] Gnome panel properties

[Philipp Kaluza <floss ghostroute eu>]

Am 28.09.2013 15:03, schrieb Alberts Muktupāvels:
> Hi!
>
> I have found that changing size (height) of panel does not work. Also
> clikcing show hide buttons does not work nice. Nor expand. When panel
> will be restarted it will show buttons and/or will not be expanded.
>
> How long panel have this problem? Is there any bug report?

Not as far as I know, please report it.

> Trying to find why it does not work i found function
> panel_toplevel_check_resize in panel-toplevel.c.
>
> This function does not look right to me. Second if statement does not
> make any sense. Currently we are calling gtk_widget_size_allocate when
> size is NOT changed.
>
> Removing line [container_class->check_resize =
> panel_toplevel_check_resize;] from panel_toplevel_class_init and
> function itself makes size change work good.

It is an implementation of
https://developer.gnome.org/gtk3/stable/GtkContainer.html#gtk-container-check-resize
which doesn't document at all what it's supposded to be doing.

Do you know what it needs to do ? Could you investigate / ask on #gtk ?

> Still there will be problems with expand and show hide buttons, but
> now it will be size (width) problem. Which will be other thing to fix.
>
> So my question - is it safe to remove that function or there was good
> reasons for it? In my case it works best without that function.

Let's not reimplement it blingly without unserstanding what it's
supposed to be doing.

Please describe exactly what your error is in the bug report, so we can
reason about it.


Cheers
  Philipp

-- 
Philipp Kaluza
Ghostroute IT Consulting