Re: [gnome-db] API Break Request for gda_insert_row_into_table

["Daniel Espinosa" <esodan gmail com>]

Thanks for your help.

I have a question:

I'm implementing most of the gda-easy functions, but found that:

GdaRepetitiveStatement *gda_prepare_insert_row (const gchar *table, GError ** error, ...)

GdaRepetitiveStatement *gda_prepare_update_row (const gchar *table, GError ** error, ...)

GdaRepetitiveStatement *gda_prepare_delete_row (const gchar *table, GError ** error, ...)

gboolean *gda_append_values_list (GdaRepetiveStatement *rstm, GError **error, ...)

Could be:

GdaRepetitiveStatement *gda_repetitive_statement_prepare_insert_row (const gchar *table, GError ** error, ...)

GdaRepetitiveStatement *gda_repetitive_statement_prepare_update_row (const gchar *table, GError ** error, ...)

GdaRepetitiveStatement *gda_repetitive_statement_prepare_delete_row (const gchar *table, GError ** error, ...)

gboolean *gda_repetitive_statement_append_values_list (GdaRepetiveStatement *rstm, GError **error, ...)

What do you think?

2008/12/30 Vivien Malerba <vmalerba gmail com>

2008/12/29 Daniel Espinosa <esodan gmail com>

2008/12/29 Daniel Espinosa <esodan gmail com>

I have a problem when implementing:

gda_prepare_insert_row

and

gda_append_insert_row

For the first, now it creates correctly the required GdaStatement and returns a GdaBatchStatement.

Bur for the second one, I found that *gda_set_set_holder_value* doesn't accept GValue* to set the required Holder, but the value, then for my porpouse I want to use this functions with GValues in order to now the values to set to the holder. I have two options:


1. Use GValue and gets its internal value to use with *gda_set_set_holder_value*

2. Append a new *gda_set_set_holder_value_from_value* to GdaSet in order to this job directly

What do you think?

I can add a new option:


3. Use gda_set_get_holder and set the value to the holder, but I found that this function, doesn't set error if the holder is not found! like gda_set_set_holder_value, then if the holder is not found I can't get any feed back. (Now I'm using this option, but would like to know what about to get an error feed back!)

This  3rd option is the way to go. If the GdaHolder can't be found, then return an error of your own (or with the domain/code GDA_SET_ERROR, GDA_SET_HOLDER_NOT_FOUND_ERROR).

Here is attached a modified version of the .c and .h files which you can the improve if necessary.

Send me a patch when you have it all wrapped.

Thanks,

Vivien

-- 
Trabajar, la mejor arma para tu superación
"de grano en grano, se hace la arena" (R) (en trámite, pero para los cuates: LIBRE)