Re: [gnome-db] API Break Request for gda_insert_row_into_table

["Daniel Espinosa" <esodan gmail com>]

For GType to String and String to GType I found the following:

gda_g_type_from_string

This function doesn't use the standard g_type_from_name and the name of the string it checks doesn't correspond with the standard g_type_name retuning string

gda_g_type_to_string

This function use the standard g_type_name, but the above don't.

But even after applying the attached PATCH (its a mix with the GdaBatchStatement) the error doesn't desapear:


Could not determine GType for parameter '2+:string:N'

Is the "2+:string:N" a correct strin to create a paramenter using 'gda_sql_param_spec_new'?

2008/12/27 Daniel Espinosa <esodan gmail com>

Sorry here is the PATCH.

2008/12/27 Daniel Espinosa <esodan gmail com>

I have almost finished. I have added a propoused GdaBatchStatement new object to manage one GdaStatement and the GdaSet objects with the values to use when execute that statement, and added a new gda_connection_batch_statement_execute in order to run this new Batch type. Attached you will find the PATH for it.


To test it I'm working in the GdaEasy functions to easy construct and add new values to a GdaBatchStatement, but I have a problem with parameters type. For the moment you need to prepare (create the GdaBatchStatement) with the column name and GType, but when convert this GType to string using g_type_string the LibGDA returns an error for G_TYPE_STRING ones:

Could not determine GType for parameter '2+:gchararray:N'

In documentation for strings LibGda use 'string' to detemine the type of the parameter, are there any way to get this names used by libgda using a GType? if not, where can I found the names used by libgda in order to make this 'translation'?

2008/12/24 Vivien Malerba <vmalerba gmail com>

2008/12/24 Daniel Espinosa <esodan gmail com>

2008/12/23 Vivien Malerba <vmalerba gmail com>

2008/12/21 Daniel Espinosa <esodan gmail com>

Hi all

I'm working in gda_insert_row_into_table but have some troubles:

I'm creating the SQL usin GdaSqlStatement structs, with success but strings are renderer with out quotes ("") can any help me to know how can I do this to work.

I'm adding a GdaSqlExpr to values GList in the GdaSqlStatementInsert, when render the GdaSqlStatement I get:

 INTO test (q, number, a) VALUES (NEW TEXT, 1000, NUEVO NOMBRE)

it is an invalid SQL, how can I get quoted strings. This must be

 INTO test (q, number, a) VALUES ('NEW TEXT', 1000, 'NUEVO NOMBRE')

for a PostgreSQL database.

It's up to you to add quotes where they are needed (because the GdaSqlStatement is just a tree representation of an SQL statement). Anyway, what you should do is use GdaSqlParamSpec (which are variables or parameters), this will have the following benefits:
* avoid you the job of adding quotes when needed
* avoid any SQL injection problems
 

Coul you help me on how create a GdaSqlParamSpec?


As Far As I Undertand for the code in gda_sql_param_spec_new (GValue *value), the value paramenter must be a string with the following syntax:

"PARAM_NAME:G_TYPE_INT:N"


As a collateral efect all functions in sql-parser directory doesn't have any documentation, then may is time to work on them, I'll try to help on them.

This API is the one exposed from the SQL parser, but as simple structures are used, they can be created using g_new() as well. This is what is done in the rest of Libgda. For examples, see the gda_compute_unique_table_row_condition() function in the gda-util.c file.

For a real "user" level API I had the idea that maybe we could create an API similar to SQLBuilder (http://openhms.sourceforge.net/sqlbuilder/), but I haven't yet had the time to investigate...

Regards,

Vivien
 

--
Trabajar, la mejor arma para tu superación
"de grano en grano, se hace la arena" (R) (en trámite, pero para los cuates: LIBRE)

--
Trabajar, la mejor arma para tu superación
"de grano en grano, se hace la arena" (R) (en trámite, pero para los cuates: LIBRE)

-- 
Trabajar, la mejor arma para tu superación
"de grano en grano, se hace la arena" (R) (en trámite, pero para los cuates: LIBRE)