[Glade-devel] One-liner fix.



Hi

Following is a one liner fix. A thing to note is that both functions
glade_widget_class_get_by_name (), and glade_widget_class_get_from_name ()
are supposed to do the same thing (atleast I think so). They why do we have 2
of them? We should remove the old/not-used anymoreone if possible.

Review for commit.
Archit Baweja


===File ~/Projects/gnome2/glade3-glade-widget-load-fix.patch===
? autom4te-2.53.cache
? glade-3.desktop
? stamp-h1
? src/foo.glade3
? src/foobar.glade3
? src/glade-3
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/glade3/ChangeLog,v
retrieving revision 1.194
diff -u -r1.194 ChangeLog
--- ChangeLog   24 Aug 2003 21:35:36 -0000      1.194
+++ ChangeLog   25 Aug 2003 08:29:24 -0000
@@ -1,3 +1,9 @@
+2003-08-25  Archit Baweja  <bighead users sourceforge net>
+
+       * src/glade-widget.c (glade_widget_new_from_node_real): replace call to
+       glade_widget_class_get_by_name to glade_widget_class_get_from_name.
+       Fixes .glade load bug.
+
 2003-08-24  Joaquin Cuenca Abela  <e98cuenc yahoo com>
 
        * src/glade-widget-class.c (glade_widget_class_remove_duplicated_properties): 
Index: src/glade-widget.c
===================================================================
RCS file: /cvs/gnome/glade3/src/glade-widget.c,v
retrieving revision 1.69
diff -u -r1.69 glade-widget.c
--- src/glade-widget.c  21 Aug 2003 14:02:23 -0000      1.69
+++ src/glade-widget.c  25 Aug 2003 08:29:48 -0000
@@ -1292,7 +1292,7 @@
 
        if (!class_name || !widget_name)
                return NULL;
-       class = glade_widget_class_get_by_name (class_name);
+       class = glade_widget_class_get_from_name (class_name);
        if (!class)
                return NULL;
        widget = glade_widget_new_full (class, project, parent);
============================================================




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]