Re: [Geary] Geary title bar on Ubuntu

[Michael Gratton <mike vee net>]

On Wed, Oct 12, 2016 at 3:08 AM, Adam Dingle <adam medovina org> wrote:
> First, one piece of good news: the build of Geary 0.11.2 that comes 
> with Ubuntu 16.10 now looks and works fine (i.e. just like 
> preinstalled GNOME apps in Ubuntu).  Ubuntu is evidently not patching 
> Geary, so I'm not sure what changed - perhaps something in the Ubuntu 
> GTK stack.
>
> Given this, we may not want to file a Launchpad bug, since the Geary 
> that comes with Ubuntu is OK (but see my comments below).

Great! Good to know, ta.

> Oh, I see.  Again, I've enabled Ubuntu's setting to show the menu in 
> the title bar.  The properties are
>
>   gtk-shell-shows-app-menu: TRUE
>   gtk-decoration-layout: "close,minimize,maximize:"

Ah, okay, so it seems you're also falling victim to 
<https://bugzilla.gnome.org/show_bug.cgi?id=770617>, which we now also 
have WIP patch for.

> > I'd like to approach the issue from both ends - talk to Ubuntu to 
> > work out what they can do, and look at what Geary can do upstream to 
> > help out. Are you happy to open the LP bug?
>
> We should open a Launchpad bug only if we want the Unity-specific 
> code to live in a patch at Canonical.  If so, we could open a 
> Launchpad bug targeting Geary 0.12 (since there is apparently no 
> issue for 0.11) and attach a patch there, which would presumably be 
> applied when Ubuntu ships Geary 0.12 (likely in 17.04).
>
> If, however, we plan to restore the Unity code as Khurshid suggested 
> in https://bugzilla.gnome.org/show_bug.cgi?id=772546 then I think 
> there is no need for a Launchpad bug.
>
> Mike, as I've said I think this is primarily up to you, so let us 
> know - thanks.

I'm not opposed to carrying small changes to support non-GNOME DE's. 
Especially for desktops that are otherwise GTK+ friendly, and given 
packaging tech like Flatpak will make it more likely that people are 
more likely to run a sock Geary, it's seems like a reasonable course of 
action.

Given that, and since Ubuntu seems like they are committed to fixing 
outright bugs like the ones Khurshid mentioned, and as you mentioned 
before the current differences between different DE's aren't likely to 
go away any time soon, let's keep DE-specific changes in Geary's 
codebase as long as they aren't too intrusive.

Does that sound like a plan to everyone?

//Mike

--
⊨ Michael Gratton, Percept Wrangler.
⚙ <http://mjog.vee.net/>