Re: [gdm-list] [PATCH] fix gdmflexiserver
- From: Ray Strode <halfline gmail com>
- To: Christiaan Welvaart <cjw daneel dyndns org>
- Cc: gdm-list gnome org
- Subject: Re: [gdm-list] [PATCH] fix gdmflexiserver
- Date: Mon, 8 Aug 2011 10:38:30 -0400
Hey,
On Sun, Jul 17, 2011 at 7:20 AM, Christiaan Welvaart
<cjw daneel dyndns org> wrote:
> commit
> http://git.gnome.org/browse/gdm/commit/?id=0e6f294c34a4222af0e0540ab124a57269c35b09
>
> broke gdmflexiserver, the attached patch fixes this.
>
> The 'ret' local in goto_login_session is used as a status flag, so assigning
> it the new return value of get_login_window_session_id breaks the remaining
> part of the function.
>
> Assigning NULL to session_id in get_login_window_session_id() and then
> dereferencing it doesn't look right either.
Thanks, I've commit changes for this in master now:
http://git.gnome.org/browse/gdm/commit/?id=977f5289a6969b5a31233bcfb4f998cdc42f53fa
http://git.gnome.org/browse/gdm/commit/?id=bb471032cf12faff7e23d784b6d378e7a028868d
--Ray
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]