Re: FSpotFS

[Matias Aguirre <matiasaguirre gmail com>]

Excerpts from Robin Clarke's message of Thu Jun 03 05:44:53 -0300 2010:
> Hey Matias,

Hi Robin,

> I tried it out - pretty neat!  Great work!

Thanks.

> I had to make a small change on lines 29 and 353 to allow database
> version 17.1

Which changes were needed? Could you send me a diff?

> Some points:
> 
>     * When I make changes in the database (add new tags, change tag
>       names), these aren't rendered in the mounted folder, but old tags
>       which no longer exist still render a file list.  Could it be that
>       the database is being loaded once on initialisation, cached and
>       not queried again?

Yes, that's correct, I'm caching database operation, it's much faster on
this way, but something that I'm not comfortable enough and have been
thinking on ways to get rid of it.

>     * AFAIK FUSE filesystems, should be mounted as the user so that the
>       user (and only the user) sees it when she runs "mount".  As-is, it
>       is mounted as root, and as a result my user cannot unmount/remount
>       the fs.  I guess if I can unmount/remount as my user, then the
>       advantage of caching the tags above would outweigh realtime querying.

Nice, didn't noted the user/group issue, I'm not setting current user
and group id, issue will be fixed soon.

Anyway this shouldn't stop you from doing "fusermount -u <mountpoint>"
to umount the filesystem.

>     * If you make changes to a photo (crop, Gimp etc.), another version
>       is created.  The default_version is defined in the photos table,
>       but it seems your script takes the filename direct from the photos
>       table, and not the photo_versions table.  Possible to change?

This is an old work, so I didn't checked schema structure recently, will
have a look into it too.

> Sorry - I don't have the python/fuse skills yet to DIY.  If you give me
> access on github I can commit those two lines I changed above though. :)

Let's fork it and request a pull with your changes, I'll be happy to
include them.

I've raised some issues to the project, you can comment, vote or raise
more of course:
    http://github.com/omab/fspotfs/issues

Thanks for the feedback.
Matías


> On 31/05/10 23:59, Matias Aguirre wrote:
> > Hi list,
> >
> > A new subscriber here but one that uses F-Stop for about an year now,
> > congrats for the hard work.
> >
> > Wanted to add my little grain of sand to the project, I've developed a
> > python based FUSE filesystem to F-Spot. This is a project developed a long
> > time ago but recently updated and uploaded to github. It lacks write
> > access at the moment, but would be implemented in a near future, maybe :)
> >
> > Grab a copy from http://github.com/omab/fspotfs and play a bit with it,
> > feedback is well welcome.
> >
> > Hope you enjoy it,
> > Matías
> >   
> 
-- 
Matías Aguirre <matiasaguirre gmail com>