Re: [Fwd: [evolution-patches] [resend] patches for #20672 (gtkhtml and mailer)]

[Michel Dänzer <michel daenzer net>]

On Thu, 2003-11-13 at 13:33, Not Zed wrote:
> 
> On Wed, 2003-11-12 at 06:05, Michel D�er wrote: 
> > On Tue, 2003-11-11 at 22:28, Radek Doul�wrote:
> > > 
> > > looks like you aim at two flies at once. If I understand it well, there
> > > are two things:
> > > 
> > >      1. stop composer autosaving when there are no changes from last
> > >         save
> > > 
> > >      2. make evolution restore all composers after crash/shutdown (even
> > >         if they don't contain any changes from initial and/or saved
> > >         state)
> > > 
> > > 1st is addressed by my patch and fixes an actual bug. That I would like
> > > to be reviewed by Jeff/Michael (Cc-ing you as it looks like you missed
> > > that thread?) and go to 1.4.x.
> 
> I'm not sure we care about this enough in 1.4.x, to be honest.  Do
> we?  1.4.x is good enough in this respect.  Auto-saving is fast enough
> not to notice it.

If that were true, I wouldn't bother about it.


> > > 2nd is rather new feature, so it should be discussed and eventually go
> > > to 2.0.
> > 
> > Why is that a new feature? When I open a composer, and then evo crashes,
> > why shouldn't the composer be restored the next time, even if I didn't
> > make any changes in it? That's a bug in my book.
> Well, FWIW I would find it pretty weird to behave like this.  If you
> haven't actually written anything, then you haven't lost anything
> either.  

I've lost the composer, so I may forget about writing something I wanted
to.

> Does your evolution really crash that often?  Mine certainly doesn't.

It doesn't crash often, but IMAP still tends to hang a couple of times a
day for me. The crash was just an example anyway.

On Thu, 2003-11-13 at 16:43, Radek Doul�wrote: 
> 
> I see one scenario where that can be useful: you read a lot of mail and
> don't want to reply immediately. so you just open reply composer and
> continue reading mail. you will end up with a lot of open composers
> after you finish reading. then you start subsequently writing replies.
> if it crashes (which is unlikely ;) you just restart evo. also when you
> have to interrupt it, you may start evo later and continue replying.
> 
> Is the above scenario you have on mind Michel?

Yes, that's precisely my every day evo usage. The persistent composers make
for a nice todo list. :) Autosaving is my personal evo killer feature.


> > > I think the point 2. of your test case should autosave immediately
> > > before saving to get consistent behavior. (if evo crashes between save
> > > draft and autosave one minute later, composer will not be recovered on
> > > evo start) 
> > 
> > Well, actually it will, but the version autosaved shortly before saving.
> Which is a bug, by any measure.  It should always be the last version
> saved.  Givne you're hitting i/o anyway its an ideal time to schedule
> an auto-save too.

Agreed, I merely pointed out the actual current behaviour.


> > > That new feature makes sense to me. As you pointed out it will need also 
> > > changes to evolution closing code - to be able quit without closing all 
> > > the composer windows. (should fire question dialog asking whether you 
> > > want to quit evolution with unfinished composers and recover them on 
> > > next start)
> > 
> > Actually, I'd like it to behave again as 1.2 (or was it way back in 1.0?
> > :) used to, i.e. keep composers autosaved on exit and recover them on
> > startup, no questions asked. A kind of session management for composers,
> > if you will.
> No you don't, 1.2 (or maybe it was 1.0) didn't recover ANY saved
> sessions till you started to write a new mail!

Right (been a while :), but the point is: everything was autosaved and
recovered without bothering me about it (or did it already ask before
recovery? My memory is failing me; I'm rather positive composers were
autosaved on normal exit without any fuss though).

Why anyone ever _wouldn't_ want the autosaved composers to be recovered
is beyond me, maybe I'm missing something?

> I'd be pretty surprised if anything changed along the way other than
> improvements anyway.

Recovery on startup is certainly an improvement, but I find the dialogs
about it and about 'save or lose' on exit annoying.

If there's no consesus on the One True Way for this, make it an option?
'Close composers on exit'? Even gconf only would be fine with me.


> FWIW I like Radek's patch better, since it is a little simpler.  Maybe
> the missing features from it can be added to finish it off?

Hopefully, I think I'd be happy if it autosaved on composer creation and
on save.


-- 
Earthling Michel D�er      |     Debian (powerpc), X and DRI developer
Software libre enthusiast    |   http://svcs.affero.net/rm.php?r=daenzer