Re: [Fwd: [evolution-patches] [resend] patches for #20672 (gtkhtml and mailer)]

[Radek Doulík <rodo ximian com>]

Hi Michel,

looks like you aim at two flies at once. If I understand it well, there
are two things:

     1. stop composer autosaving when there are no changes from last
        save
     2. make evolution restore all composers after crash/shutdown (even
        if they don't contain any changes from initial and/or saved
        state)

1st is addressed by my patch and fixes an actual bug. That I would like
to be reviewed by Jeff/Michael (Cc-ing you as it looks like you missed
that thread?) and go to 1.4.x.

2nd is rather new feature, so it should be discussed and eventually go
to 2.0.

I think the point 2. of your test case should autosave immediately
before saving to get consistent behavior. (if evo crashes between save
draft and autosave one minute later, composer will not be recovered on
evo start) That new feature makes sense to me. As you pointed out it
will need also changes to evolution closing code - to be able quit
without closing all the composer windows. (should fire question dialog
asking whether you want to quit evolution with unfinished composers and
recover them on next start) Michael, Jeff, what do you think about this?

Cheers
Radek

On Tue, 2003-11-11 at 14:06, Michel Dänzer wrote:
> On Tue, 2003-11-11 at 12:49, Radek Doulík wrote: 
> > On Sun, 2003-11-09 at 02:04, Michel Dänzer wrote:
> > > On Thu, 2003-11-06 at 16:02, Radek Doulík wrote: 
> > > > 
> > > > I thought about that bug again and I think we don't need any change on
> > > > gtkhtml's side. I am attaching composer fix (autosave.fix) and your
> > > > evolution-changed.diff patch. Could you test that the fix works for you?
> > > 
> > > It doesn't work very well; e.g. it doesn't autosave once after a
> > > composer is created,
> > 
> > that's a feature IIRC 
> 
> I beg to differ. When I open a composer, I don't want it to disappear by
> itself. Ever. (Yes, I consider the fact that they do disappear - unless
> I save them all, ugh - when quitting evo a bug - I always use
> --force-shutdown instead)
> 
> > if it's wanted it has to be done at composer creation time (force an autosave).
> 
> Curious, how would you do that?
> 
> 
> > I found your patch unnecessarily complicated, sorry. 
> 
> I'm not sure it's unnecessarily so. :\
> 
> > I think the attached patch should work OK now. Do you see any other 
> > issues it has? 
> 
> Here's my test case:
> 
>      1. Open a composer (create new message, reply, whatever). Verify
>         that it gets autosaved at most after a minute.
>      2. Make changes and immediately save (as a draft, to a file...).
>         Verify that the changes get autosaved at most a minute later.
>      3. Close the composer. It shouldn't ask about unsaved changes.
> 
> My patch passes all of these. Yours fails 1. and 2. and only happens to
> pass 3. because it fails 2. Maybe that could be fixed by also autosaving
> on saving though.
-- 
Radek Doulík <rodo ximian com>
Ximian, Inc.