Re: [Fwd: [evolution-patches] [resend] patches for #20672 (gtkhtml and mailer)]

[Michel Dänzer <michel daenzer net>]

On Tue, 2003-11-11 at 12:49, Radek Doul�wrote: 
> On Sun, 2003-11-09 at 02:04, Michel D�er wrote:
> > On Thu, 2003-11-06 at 16:02, Radek Doul�wrote: 
> > > 
> > > I thought about that bug again and I think we don't need any change on
> > > gtkhtml's side. I am attaching composer fix (autosave.fix) and your
> > > evolution-changed.diff patch. Could you test that the fix works for you?
> > 
> > It doesn't work very well; e.g. it doesn't autosave once after a
> > composer is created,
> 
> that's a feature IIRC 

I beg to differ. When I open a composer, I don't want it to disappear by
itself. Ever. (Yes, I consider the fact that they do disappear - unless
I save them all, ugh - when quitting evo a bug - I always use
--force-shutdown instead)

> if it's wanted it has to be done at composer creation time (force an autosave).

Curious, how would you do that?


> I found your patch unnecessarily complicated, sorry. 

I'm not sure it's unnecessarily so. :\

> I think the attached patch should work OK now. Do you see any other 
> issues it has? 

Here's my test case:

     1. Open a composer (create new message, reply, whatever). Verify
        that it gets autosaved at most after a minute.
     2. Make changes and immediately save (as a draft, to a file...).
        Verify that the changes get autosaved at most a minute later.
     3. Close the composer. It shouldn't ask about unsaved changes.

My patch passes all of these. Yours fails 1. and 2. and only happens to
pass 3. because it fails 2. Maybe that could be fixed by also autosaving
on saving though.


-- 
Earthling Michel D�er      |     Debian (powerpc), X and DRI developer
Software libre enthusiast    |   http://svcs.affero.net/rm.php?r=daenzer