Re: [Evolution] Evolution-3.2.2: Opening calendar to a specified date?



On Wed, 2011-12-14 at 16:36 +0530, Chenthill wrote:
On Wed, 2011-12-14 at 07:32 +0100, Milan Crha wrote:
On Tue, 2011-12-13 at 14:38 +0530, Chenthill wrote:
What I see is that the query starts with '?' parameters are
separated by '&', but don't understand why the value is assigned with
'=&'. It is the same for address-book as well. I think Matthew should
know this better.. 

http://git.gnome.org/browse/evolution/commit/?id=f2b2d42471dc6a820c94f8888bd4f13a5c00a530

    Hi,
I guess you aim at this line:
  +        header_len = strcspn (cp, "=&");
It stops on the first character from "=&". Then it checks it stopped on
'=', as it's supposed to be the parameter name, 
Nope, it checks if the query is malformed, ie. "==&". Notice the comment
and break statement.  It might be that checking for "=&" could be a
mistake..
Hmm. Am wrong. Thanks milan for correcting me over irc.. Milan would be
committing an updated fix for the same.

- Chenthill.

- Chenthill.
then, few lines below,
searches for the ending '&', as it's the separator between parameters.
That means the value is not assigned with "=&".

Maybe I just misunderstood something, and if so, please correct me.
    Bye,
    Milan

_______________________________________________
evolution-list mailing list
evolution-list gnome org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-list







[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]