Bug 343282 – memory leak when reloading

[Ricardo Markiewicz <rmarkie fi uba ar>]

I'm trying to reproduce this bug without lucky, can anyone confirm if
this still happend?

I saw that 'ps uax' show an increment of memory usage, but is nothing
compared to the original report :
gazer    24912 84.7  2.7  42712 21596 pts/0    Sl+  00:03   0:06 evince
kdvi.pdf
(after 3 reloads)
gazer    24912 71.6  2.9  42336 23068 pts/0    Sl+  00:03   1:07 evince
kdvi.pdf

valgrind report many "XXX bytes in Y blocks are definitely lost in loss
record", mostly in Gtk+ and GnomeProgram, but I need to check that
before report those problems as bugs.

The only thing I found is a minor memory leak in ev-window.c (patch
attached).

Thanks

[1]: http://bugzilla.gnome.org/show_bug.cgi?id=343282
-- 
Ricardo Markiewicz // http://www.fi.uba.ar/~rmarkie/

Index: shell/ev-window.c
===================================================================
RCS file: /cvs/gnome/evince/shell/ev-window.c,v
retrieving revision 1.290
diff -u -r1.290 ev-window.c
--- shell/ev-window.c	26 Jul 2006 15:27:37 -0000	1.290
+++ shell/ev-window.c	4 Aug 2006 02:42:30 -0000
@@ -636,6 +636,7 @@
 	if (ev_metadata_manager_get (uri, "sidebar_size", &sidebar_size, FALSE)) {
 		gtk_paned_set_position (GTK_PANED (window->priv->hpaned),
 					g_value_get_int (&sidebar_size));
+		g_value_unset (&sidebar_size);
 	}
 	
 	if (document && ev_metadata_manager_get (uri, "sidebar_page", &sidebar_page, FALSE)) {
@@ -648,12 +649,14 @@
 		} else if (strcmp (page_id, ATTACHMENTS_SIDEBAR_ID) && ev_sidebar_page_support_document (EV_SIDEBAR_PAGE (attachments), document)) {
 			ev_sidebar_set_page (EV_SIDEBAR (sidebar), thumbs);
 		}
+		g_value_unset (&sidebar_page);
 	} else if (document && ev_sidebar_page_support_document (EV_SIDEBAR_PAGE (links), document)) {
 		ev_sidebar_set_page (EV_SIDEBAR (sidebar), links);
 	}
 
 	if (ev_metadata_manager_get (uri, "sidebar_visibility", &sidebar_visibility, FALSE)) {
 		update_chrome_flag (window, EV_CHROME_SIDEBAR, g_value_get_boolean (&sidebar_visibility));
+		g_value_unset (&sidebar_visibility);
 	}
 }