Re: [Ekiga-devel-list] celt option fails to build

[Damien Sandras <dsandras seconix com>]

Le lundi 09 février 2009 à 22:26 +0100, Peter Robinson a écrit :
> Hi Eugen,
> 
> >> Have you find out where's the problem?
> >
> > No. I'm running the latest opal celt code from cvs and it still fails
> > to build as per the last email I sent. It could be a compiler option
> > that Fedora uses (they tend to use tighter options than a lot of
> > distros do) or possibly gcc 4.4 which is now in rawhide (although it
> > doesn't affect the rest of opal except the small patch Damien's
> > already applied).
> 
> As a follow up to this. The build output is below, the complete output
> can be found here:
> 
> i386: http://koji.fedoraproject.org/koji/getfile?taskID=1116094&name=build.log
> x86_64: http://koji.fedoraproject.org/koji/getfile?taskID=1116093&name=build.log
> 
> make[2]: Entering directory
> `/builddir/build/BUILD/opal-3.5.2/plugins/audio/celt'
> gcc -c -fPIC -Os -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
> -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32
> -march=i386 -mtune=generic -fasynchronous-unwind-tables
> -I../../../include -I../..  -o celtcodec.o celtcodec.c
> celtcodec.c: In function 'celt_codec_encoder':
> celtcodec.c:147: warning: passing argument 3 of 'celt_encode' from
> incompatible pointer type
> /usr/include/celt/celt.h:182: note: expected 'celt_int16_t *' but
> argument is of type 'char *'
> celtcodec.c:147: warning: passing argument 4 of 'celt_encode' makes
> pointer from integer without a cast
> /usr/include/celt/celt.h:182: note: expected 'unsigned char *' but
> argument is of type 'int'
> celtcodec.c:147: error: too few arguments to function 'celt_encode'
> celtcodec.c: In function 'celt_codec_decoder':
> celtcodec.c:174: warning: pointer targets in passing argument 2 of
> 'celt_decode' differ in signedness
> /usr/include/celt/celt.h:227: note: expected 'unsigned char *' but
> argument is of type 'char *'
> make[2]: *** [celtcodec.o] Error 1
> make[2]: Leaving directory `/builddir/build/BUILD/opal-3.5.2/plugins/audio/celt'
> make[1]: Leaving directory `/builddir/build/BUILD/opal-3.5.2/plugins'
> make[1]: *** [all] Error 2
> make: *** [subdirs] Error 2
> make:
> *** Waiting for unfinished jobs....

If you look at plugins/audio/celt/celtcodec.c, line 147 does not exist.
However, you have that block starting at line 146 :
#ifdef HAVE_CELT_0_5_0_OR_LATER
  byteCount = celt_encode(celt->encoder_state, (celt_int16_t *)fromPtr,
NULL, (char *)toPtr, celt->bytes_per_packet);
#else
  byteCount = celt_encode(celt->encoder_state, (celt_int16_t *)fromPtr,
(char *)toPtr, celt->bytes_per_packet);
#endif


Are you 100% sure your code contains this ?

Because HAVE_CELT_0_5_0_OR_LATER is defined by configure (see
plugins/configure.ac) if celt >= 0.5.0.

This should be defined in plugins/plugin-config.h

I think you do not run the code with the right patches...
-- 
 _     Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_   Be IP           : http://www.beip.be/
       FOSDEM          : http://www.fosdem.org/
       SIP Phone       : sip:dsandras ekiga net