Hi Matthias On 2013-07-05 14:18, Mathias Reineke <paperfeeder googlemail com> wrote:
Hi David, that was really fast .) On 05.07.2013 13:34, David King wrote:I had to change the UI a little, and hope that I did not destroy the Look. Please adjust my UI changes to follow your style guidelines.Unfortunately, there is not room in the tag view for more tag fields, and there is already a bug open about improving the UI to make it take up less vertical space: https://bugzilla.gnome.org/show_bug.cgi?id=689438Hmmm, I will have a look at that issue, but I mus mention that I have little clue of GTK.
Please do not feel that you have to investigate this immediately, but know that there a few changes blocked on reducing the vertical space taken up by the current UI. There are many tag fields which are not supported by EasyTAG, and a more flexible UI layout would help with supporting those as well. I will get around to it myself at some point, but I do not have time at the moment.
Please ensure that you keep the mailing list CCd in your replies, as otherwise your messages will not be sent to others on the mailing list.Oh, I must have hit the wrong "reply" button, I'm sorry for that. Let's see if it now works.
Perfect now, thanks.
It would be good if you could split the changes up into smaller patches so that they are easier to review.Yes. This was caused by the fact that I did not use a VCS creating the changes. The next commits will be significantly smaller.
If you could split your existing large patch, that would be even better. You can do this in several ways with git, but my approach would be to reset to the commit before, then use "git add -p" to slowly add changes in to newer (and smaller) commits). I would suggest that changes which solve a specific problem, such as the track model bugfix, being separate commits.
There were also some Eclipse project files, which should not be added to git.I'm not into the way you compare the repositories, are these files annoying? Since I share repos across different computers, it is vital for me to keep the Eclipse metadata in VCS.
Yes, my general rule is that generated files should not be in git. For example, the build system for EasyTAG is not kept in git, but generated locally with autogen.sh (and updated) whenever it is needed. If you need these files for yourself, then I would suggest putting them in a branch which you can merge locally but keep out of upstream git. I appreciate that this is more awkward than your current approach, but at least git makes it possible to work in a very different way locally to remotely.
For the German translations, they go through the GNOME Translation Project: https://wiki.gnome.org/TranslationProjectI was not aware of that, but I thought something like this, that's why I translated only two sentences. I am quite new to Gnome, and willing to learn.
It is not a problem, except that I cannot review the translations myself, and the GNOME translation teams seem to have a good reputation of maintaining a high-quality set of translations. If you have translation improvements, contacting the German team is likely the fastest way to get them merged:
https://l10n.gnome.org/teams/de/ -- http://amigadave.com/
Attachment:
signature.asc
Description: Digital signature