Hi Mathias On 2013-07-05 12:51, Mathias Reineke <paperfeeder googlemail com> wrote:
thanks for that information. I'm glad that you are interested in my changes. I hope I did everything conform to your style of coding. On 04.07.2013 16:10, David King wrote:The best way is probably to post a git branch on github, Gitorious or a similar hosting site.I have created a fork on GitHub, found under: https://github.com/saihtam-r/easytag containing the changes. I had to change the UI a little, and hope that I did not destroy the Look. Please adjust my UI changes to follow your style guidelines.
Unfortunately, there is not room in the tag view for more tag fields, and there is already a bug open about improving the UI to make it take up less vertical space:
https://bugzilla.gnome.org/show_bug.cgi?id=689438
Yes, I have seen that there were many changes. I did my best to merge mine into the master view, so you should see only relevant changes when comparing the two repositories.
Thanks, I appreciate the effort.
Please send an email to the mailing list once you have posted your changes.Which I now have done :)
Please ensure that you keep the mailing list CCd in your replies, as otherwise your messages will not be sent to others on the mailing list.
If you had time to review the stuff, I would appreciate feedback on the changes.
It would be good if you could split the changes up into smaller patches so that they are easier to review. There were also some Eclipse project files, which should not be added to git. For the German translations, they go through the GNOME Translation Project:
https://wiki.gnome.org/TranslationProject Thanks! -- http://amigadave.com/
Attachment:
signature.asc
Description: Digital signature